feat(backend): implement ClearTask and MarkTaskSuccess actions with scope, cache-invalidation, and comments. - #13996
Conversation
…cope, cache-invalidation, and comments Signed-off-by: Shresth Singh <shresthengineer@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @singhshresth26. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of your changes:
This PR implements manual, per-task lifecycle controls for in-flight or failed pipeline runs. It adds backend support for scoped Clear (re-run task) and Mark Success (manually override task outcome) actions in coordination with the underlying Argo Workflow engine.
Key Additions:
run.proto):TaskScopeenum (TASK_ONLY,DOWNSTREAM,UPSTREAM,UPSTREAM_DOWNSTREAM).ClearTaskRequest(includesinvalidate_cacheoption) andMarkTaskSuccessRequest(includes mandatorycommentfield).RunService(:clear,:marksuccess).run_server.go):retrypermission for clearing tasks andupdatepermission for marking success.resource_manager.go):FormulateRetryWorkflowutility, safely preserving output and boundary IDs.invalidateCacheis enabled, appends the--cache_disabledargument to the task template definition inworkflow.Specso KFP driver bypasses the MLMD execution cache on retry.Succeededand records the reason/comment in the node's statusMessagefield for an audit trail.run_server_test.gochecking validation constraints, cache-invalidation templating, phase updates, and audit comments.Checklist:
fixes #13883